Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particles: adds amount property to collision sub particles. #66349

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

A-Lamia
Copy link
Contributor

@A-Lamia A-Lamia commented Sep 24, 2022

Gives collision sub particles the same function as at end sub particles so you can select the amount you want instead of being hard coded to 1 particle.

Can be merged to 3.X if fully supports GPU particles / Collisions.

Before:

godot.windows.opt.tools.x86_64_3xJlr3i4G.mp4

After:

godot.windows.tools.x86_64_7Vse0gb2AFT.mp4

@A-Lamia A-Lamia requested a review from a team as a code owner September 24, 2022 12:30
@Calinou
Copy link
Member

Calinou commented Sep 24, 2022

Can be merged to 3.X if fully supports GPU particles / Collisions.

3.x has GPU-based Paticles, but it supports neither collision nor subemitters.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once the docs are filled in this should be ready to merge

doc/classes/ParticleProcessMaterial.xml Outdated Show resolved Hide resolved
@A-Lamia A-Lamia force-pushed the Amount_At_Collision branch 2 times, most recently from 19910bf to c86d1ed Compare October 12, 2022 05:41
@akien-mga akien-mga merged commit c55c0a2 into godotengine:master Oct 13, 2022
@akien-mga
Copy link
Member

Thanks!

@A-Lamia A-Lamia deleted the Amount_At_Collision branch October 13, 2022 09:35
@akien-mga akien-mga changed the title PARTICLES: adds amount property to collision sub particles. Particles: adds amount property to collision sub particles. Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants