Add searching by event in Editor Settings shortcuts and Project Settings input map. #66770
Conversation
| @@ -35,6 +35,100 @@ | |||
| #include "editor/editor_scale.h" | |||
There was a problem hiding this comment.
Might be time to split this file up. It contains 3 classes now. I would do it in another pr tho.
EricEzaM
force-pushed
the
search-by-event
branch
2 times, most recently
from
0af967a
to
f4dbd96
Compare
EricEzaM
force-pushed
the
search-by-event
branch
2 times, most recently
from
9636422
to
dacfd1e
Compare
There was a problem hiding this comment.
Seems like a good feature to have:
A minor issue - it's possible to input text input the filter LineEdit if you keep pressing the same letter key, e.g., pressing F multiple type will result in fffffffF in the filter.
Also, I'm not sure about "Filter by event... (perform input here)", it's a bit too long. Maybe it's better to display only Filter by event... by default and change it to Listening for input... when it's focused, or something like this.
What a great idea, can't believe I didn't think of this! |
EricEzaM
force-pushed
the
search-by-event
branch
from
dacfd1e
to
cb6d7fd
Compare
…ings input map. * Focus into the LineEdit, then perform input to search the list of events by the events assigned. * New specialised editor-only control for this: EventListenerLineEdit. Line edit is a good candidate for such a control because you can focus it, override it's input handling, and show the event all in one control. Update InputEventConfigurationDialog to use event listener line edit rather than the separate tabs. * Cleaner look - no need for tabs. * Simpler code.
|
Those 2 are fixed now, thanks! |
|
Thanks! |
|
Don't know if this is really the right place too put this, but i found a bug with the input search. That when you press Esc it will close the window while listening for inputs. inputsDontCanelOutEsc.mp4 |
It's not, open a new issue. |
LineEdit, then perform input to search the list of events by the events assigned.EventListenerLineEdit. Line edit is a good candidate for such a control because you can focus it, override it's input handling, and show the event all in one control.Update
InputEventConfigurationDialogto use event listener line edit rather than the separate tabs.Please note the preview text in the LineEdit has now been changed from what is in the videos below. New is like so Unfocused: "Filter by event..." Focused: "Listening for input..."
Shortcuts Search
godot.windows.editor.dev.x86_64_WS0WTY1oqO.mp4
Input map Search
godot.windows.editor.dev.x86_64_WkMVTLmtPJ.mp4
New Event Picker (no more tabs!) (can now pick escape from the keyboard and close the window with escape too!)
godot.windows.editor.dev.x86_64_HQ7AsoJMa3.mp4