Fix drawing of 2D primitives in OpenGL3 renderer #67416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
approved these changes
Oct 14, 2022
Previously the wrong vertices were used when assembling the second triangle of a quad
clayjohn
force-pushed
the
GLES3-primitive
branch
from
51a208f
to
6d048af
Compare
akien-mga
approved these changes
Oct 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #67412
Previously the wrong vertices were used when assembling the second triangle of a quad.
In the RD renderer the logic looks a bit different. It loops over only j=1 to j=2. It doesn't need to run j=0 because it is writing over the same array used by the first vertex. In GLES3, since we batch draw calls, the data for all 6 vertices needs to be copied over.