Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS export] Add support for Xcode notarytool. #69638

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 6, 2022

Adds support for new Xcode 13+ notarytool. In addition to the old altool (which is still supported until fall 2023 and usable for older Xcode versions).

Fixes godotengine/godot-proposals#5898

@akien-mga akien-mga added enhancement cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Dec 6, 2022
@akien-mga
Copy link
Member

Not urgent but I noticed this warning for official builds too, so we'll have to update https://github.com/godotengine/godot-build-scripts/blob/main/build-release.sh#L53

As a side note, rcodesign moved to a new repo dedicated to Apple tools in Rust: https://github.com/indygreg/apple-platform-rs/tree/main/apple-codesign
But I don't think we refer to it by URL so this is just an FYI / relevant for our docs eventually.

@bruvzg
Copy link
Member Author

bruvzg commented Dec 6, 2022

Not urgent but I noticed this warning for official builds too, so we'll have to update https://github.com/godotengine/godot-build-scripts/blob/main/build-release.sh#L53

This can also be simplified a bit, notarytool have --wait argument, so won't need a loop.

As a side note, rcodesign moved to a new repo dedicated to Apple tools in Rust: https://github.com/indygreg/apple-platform-rs/tree/main/apple-codesign
But I don't think we refer to it by URL so this is just an FYI / relevant for our docs eventually.

Not in the engine code, but link in the docs should be updated (godotengine/godot-docs#6456).

@bruvzg bruvzg marked this pull request as ready for review December 7, 2022 10:01
@bruvzg bruvzg requested a review from a team as a code owner December 7, 2022 10:01
@akien-mga akien-mga merged commit b3c7822 into godotengine:master Dec 7, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated altool with notarytool for macOS notarization
2 participants