Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AnimationTree / AnimationPlayer processes adopt to GDVIRTUAL #71682

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jan 19, 2023

Separated from #69802.

Exposes the virtual function GDVIRTUAL_CALL(_post_process_key_value) for AnimationPlayer and AnimationTree. This should make it possible to create a realtime retarget module as an add-on rather than a custom module. Like physics, rendering, it makes more sense to allow animations to be extended with GDExtention.

@TokageItLab TokageItLab added this to the 4.0 milestone Jan 19, 2023
@TokageItLab TokageItLab requested review from a team as code owners January 19, 2023 15:47
@TokageItLab TokageItLab changed the title Make AnimationTree / AnimationPlayer processes adopt to GDVIRTUAL Make AnimationTree / AnimationPlayer processes adopt to GDVIRTUAL Jan 19, 2023
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward. comment about constness is just a nitpick. not important.

scene/animation/animation_player.h Outdated Show resolved Hide resolved
scene/animation/animation_tree.h Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 44c0bfc into godotengine:master Jan 26, 2023
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the gdvirtual-anim-node branch February 14, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants