Make the rendering method dropdown also affect mobile if compatible #72461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2023
Calinou
force-pushed
the
editor-renderer-select-mobile
branch
from
8bd9563
to
62bbfd8
Compare
clayjohn
reviewed
Apr 12, 2023
|
More discussion on the subject: godotengine/godot-proposals#7767 |
Calinou
added
cherrypick:4.1
This prevents visual discrepancies between desktop and mobile platforms after switching rendering methods using this dropdown. The restart dialog now displays which rendering methods will be used, and the dropdown tooltip also lists caveats related to specific platforms.
Calinou
force-pushed
the
editor-renderer-select-mobile
branch
from
62bbfd8
to
57f3bdb
Compare
clayjohn
approved these changes
Jan 6, 2024
clayjohn
added
the
cherrypick:4.2
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #72460.
This prevents visual discrepancies between desktop and mobile platforms after switching rendering methods using this dropdown.
The restart dialog now displays which rendering methods will be used, and the dropdown tooltip also lists caveats related to specific platforms.
I've tested all switching combinations and can confirm it works as expected. Note that
project.godotwill not store default values, so you won't see themobilerendering method being visibly stored in that file for the.mobileoverride (butgl_compatibilitywill).Preview