Auto translate popup menus of MenuButton and OptionButton #75384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
approved these changes
Mar 27, 2023
bruvzg
reviewed
Mar 27, 2023
Currently, `auto_translate` property of a `MenuButton` or `OptionButton` won't affect its popup menu. It's okay if you want to auto translate, but requires extra setup if you don't.
timothyqiu
force-pushed
the
cultural-heritage
branch
from
059d4aa
to
150f893
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
auto_translateproperty of aMenuButtonorOptionButtonwon't affect its popup menu. It's okay if you want to auto translate, but requires extra setup if you don't. I don't think there's a practical use case for translating popup menus while not translating the buttons.This PR changes internal
PopupMenu'sauto_translateproperty when the button'sauto_translatechanges.Note: The descriptions in
Control.xmlwere later summarized based on existing behavior, rather than the design at the time of initial implementation.