Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sliding window problem in linux occur due to reparenting of the window due to decoration. #76040

Conversation

n0tank3sh
Copy link
Contributor

@n0tank3sh n0tank3sh commented Apr 13, 2023

Another solution without delay was discussed in the following PR: #75709
The caveat for this solution is that if the window manager decides to reparent the reparented window for decorations (which rarely happens in the most popular window managers), it will not work.

Fixes: #75292

…he window during the decoration via tracking the parent of the window
@YuriSizov YuriSizov merged commit f5f796b into godotengine:master Apr 14, 2023
@YuriSizov
Copy link
Contributor

Thanks!

PS. Please try to be a bit more succinct with the commit messages in the future. You could leave the title as "Fix the sliding window problem on the Linux platform" and put the rest in the commit message body as a further clarification.

@n0tank3sh n0tank3sh deleted the fix-sliding-window-linux-via-tracking-parent branch April 14, 2023 14:09
@n0tank3sh
Copy link
Contributor Author

@YuriSizov Thanks for the suggestion, I will keep that in my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows move downward by the height of their title bars each time they popup (DisplayServer regression)
3 participants