Fix CSGPolygon3D in path mode disappearing at runtime #77118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @MinusKube |
|
I should note that I also tested this with collision turned on and didn't see any errors or crashes, so hopefully that means the original bug is still fixed. |
|
Tested on a project of mine with heavy CSGPolygon3D with path usage, didn't spot a regression. I haven't tested long enough to make sure that I couldn't reproduce the bug anymore, but I did experience it back when I was making that project for a game jam. |
akien-mga
approved these changes
May 17, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #72427 in order to fix #72771.