Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention expected resource type in ResourceLoader load error #79737

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Mention expected resource type in ResourceLoader load error #79737

merged 1 commit into from
Jul 31, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 21, 2023 •
edited
Loading

This helps troubleshoot issues due to incorrect import types.

Preview

-ERROR: Resource file not found: res://example.png (expected type: Texture2D)
   at: _load (./core/io/resource_loader.cpp:278)

@Calinou
Mention expected resource type in ResourceLoader load error
5bf6425 
This helps troubleshoot issues due to incorrect import types.
@Calinou Calinou requested a review from a team as a code owner July 21, 2023 02:46
@Calinou Calinou added this to the 4.x milestone Jul 21, 2023
@Calinou Calinou mentioned this pull request Jul 21, 2023
Closed
RandomShaper
RandomShaper approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure p_type_hint will always be non-empty. However, if that ever happens, the worst case is an ugly error message that we can patch in an upcoming PR.

@clayjohn clayjohn modified the milestones: 4.x, 4.2 Jul 26, 2023
@YuriSizov YuriSizov merged commit 0be5875 into godotengine:master Jul 31, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Calinou @YuriSizov @RandomShaper @clayjohn