[macOS] Add support for loading shell environment from UI apps. #81266
Conversation
bruvzg
force-pushed
the
mac_shell_env
branch
from
5f660f4
to
bd73188
Compare
| <method name="load_shell_environment" qualifiers="const"> | ||
| <return type="void" /> | ||
| <description> | ||
| Loads the default shell and copies environment variables set by the shell startup scripts to the app environment. | ||
| [b]Note:[/b] This method is implemented on macOS for non-sandboxed applications only. | ||
| </description> | ||
| </method> |
There was a problem hiding this comment.
If it's macOS specific, is there really much need for exposing it? Sounds more like a Godot editor implementation detail than a generic API users would make use of.
There was a problem hiding this comment.
It might be useful for custom tools that are running external executables or configurable with environment variables, but still use GUI (and app bundle).
There was a problem hiding this comment.
What if we always call this method on startup (not just in the editor)? Is there a downside to always calling it?
There was a problem hiding this comment.
The only negative impact is likely start-up time. Also running a shell on every start might look suspicious.
There was a problem hiding this comment.
Then, if we don't want to expose the method maybe we can expose a project setting to determine whether to call the method at startup or not.
There was a problem hiding this comment.
I guess project setting OK as well, not sure what's better. We have plenty of OS methods that are useful only on a specific platform, or work completely differently (sandbox and permission related stuff, get_cmdline_platform_args).
Adds
OS::load_shell_environmentmethod to loadzshand copy environment variables to the macOS GUI app environment.OS::load_shell_environmentis automatically used by the editor, and can be used manually from any other non-sandboxed project.See #81240
Fixes #96409
Fixes #96596