UWP: Remove platform port, needs to be redone from scratch for 4.x #81416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UWP platform port was never ported to the Godot 4.0+ API, and it's now accumulating bitrot as it doesn't compile, and thus we no longer propagate platform changes in it. So we finally remove to acknowledge this state. There's still some interest in reviving the UWP port eventually, especially as support for Direct3D 12 will soon be merged, but when that happens it will be easiest to redo it from scratch.
vnen
approved these changes
Sep 7, 2023
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Oct 27, 2023
We had a slightly older version of it for UWP, as the wincrypt API isn't allowed there. We removed this with UWP in godotengine#81416, but since this was enabled inconditionally before, this actually changed behavior for Windows compared to Godot 4.1 and earlier. This change is also needed to properly supported Windows Store.
orianbsilva
pushed a commit
to orianbsilva/godot
that referenced
this pull request
Nov 1, 2023
We had a slightly older version of it for UWP, as the wincrypt API isn't allowed there. We removed this with UWP in godotengine#81416, but since this was enabled inconditionally before, this actually changed behavior for Windows compared to Godot 4.1 and earlier. This change is also needed to properly supported Windows Store.
GuybrushThreepwood-GitHub
pushed a commit
to GuybrushThreepwood-GitHub/godot
that referenced
this pull request
Jan 27, 2024
We had a slightly older version of it for UWP, as the wincrypt API isn't allowed there. We removed this with UWP in godotengine#81416, but since this was enabled inconditionally before, this actually changed behavior for Windows compared to Godot 4.1 and earlier. This change is also needed to properly supported Windows Store.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Mar 11, 2024
We had a slightly older version of it for UWP, as the wincrypt API isn't allowed there. We removed this with UWP in godotengine#81416, but since this was enabled inconditionally before, this actually changed behavior for Windows compared to Godot 4.1 and earlier. This change is also needed to properly supported Windows Store. (cherry picked from commit b9d008d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UWP platform port was never ported to the Godot 4.0+ API, and it's now accumulating bitrot as it doesn't compile, and thus we no longer propagate platform changes in it.
So we finally remove to acknowledge this state. There's still some interest in reviving the UWP port eventually, especially as support for Direct3D 12 will soon be merged, but when that happens it will be easiest to redo it from scratch.
This PR removes all references to UWP in the codebase (aside from thirdparty code), so if the UWP platform does get brought back from the dead at some point, I would suggest doing a selective reverse application of this patch to restore the various
UWP_ENABLEDin drivers, Windows code, modules and documentation.