Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Workaround Xcode 15 linker bug. #81968

Merged
merged 1 commit into from Sep 20, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 20, 2023

Workaround for #81948, this seems to be a linker bug in Xcode 15, and I'm not sure what exactly is causing it.

@bruvzg bruvzg added this to the 4.x milestone Sep 20, 2023
@akien-mga akien-mga added cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 20, 2023
@bruvzg bruvzg marked this pull request as ready for review September 20, 2023 09:42
@bruvzg bruvzg requested a review from a team as a code owner September 20, 2023 09:42
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 20, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably report that bug to Apple.

@akien-mga akien-mga merged commit 58750df into godotengine:master Sep 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke
Copy link
Member

and I'm not sure what exactly is causing it (3.x is not affected).

3.x is affected, I'm unable to compile the 3.x branch with the same error as master:

[100%] progress_finish(["progress_finish"], [])
[100%] Linking Static Library ==> scene/libscene.osx.tools.arm64.a
Ranlib Library         ==> scene/libscene.osx.tools.arm64.a
[100%] Linking Program        ==> bin/godot.osx.tools.arm64
0  0x10055f648  __assert_rtn + 72
1  0x100487c5c  ld::Fixup::applyFixup(ld::Atom const*, ld::LayoutLinkedImage const&, unsigned char*) const + 8268
2  0x10051a7d8  ___ZN2ld16LayoutExecutable27writeContentWithoutLinkEditENSt3__14spanIhLm18446744073709551615EEEy_block_invoke + 332
3  0x1a2a20440  _dispatch_client_callout2 + 20
4  0x1a2a33f1c  _dispatch_apply_invoke + 224
5  0x1a2a20400  _dispatch_client_callout + 20
6  0x1a2a31fb8  _dispatch_root_queue_drain + 684
7  0x1a2a326c0  _dispatch_worker_thread2 + 164
8  0x1a2bcc038  _pthread_wqthread + 228
ld: Assertion failed: (extras.otherInstrOffset != 0 && "Kind::arm64_adrp_ldr missing extra info"), function applyFixup, file Fixup.cpp, line 793.
clang: error: linker command failed with exit code 1 (use -v to see invocation)
scons: *** [bin/godot.osx.tools.arm64] Error 1
scons: building terminated because of errors.

@bruvzg
Copy link
Member Author

bruvzg commented Sep 20, 2023

3.x is affected

It's building fine for me (apart from PCRE SLJIT issue).

@bruvzg bruvzg deleted the xc15_ld_bug branch September 20, 2023 20:07
@bruvzg
Copy link
Member Author

bruvzg commented Sep 20, 2023

It's building fine for me (apart from PCRE SLJIT issue).

Actually, it only works for release build, debug build is affected.

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
@bruvzg
Copy link
Member Author

bruvzg commented Sep 28, 2023

For the reference, seems like I have narrowed down the issue to the raycast/embree module (kernels/bvh/bvh_builder_sah_spatial.cpp in particular, but I have no idea what's exactly wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling ARM64 error after installing Xcode15
4 participants