New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close ColorPicker if holding Ctrl while confirming a color selection #84447
base: master
Are you sure you want to change the base?
Close ColorPicker if holding Ctrl while confirming a color selection #84447
Conversation
I don't know about this. I've never seen a shortcut like this before. Perhaps it would be better to try updating the chosen color as you're writing it. Pressing Enter alone to close the ColorPicker sounds like it should be the default. |
I think releasing picker shape (e.g. wheel) while holding Ctrl should also close the picker. |
04d0780
to
6e42a3e
Compare
Done 🙂 I've also implemented this for the revert area (the left side of the preview that can be clicked to revert to the previous color).
We could consider doing this for HTML input, but this is a more disruptive change (while you can ignore this one if you don't need it). This can't be done for all kinds of color picking (such as using the wheel and swatches). |
6e42a3e
to
15868a2
Compare
15868a2
to
7bcb2aa
Compare
This works with the color sliders and text fields, the HTML color text field, the swatch preset buttons (manual presets and recent colors), the revert area and the color picker area (UV and W).
7bcb2aa
to
ac684e3
Compare
This works with the color sliders and text fields, the HTML color text field, the swatch preset buttons (manual presets and recent colors), the revert area and the color picker area (UV and W).
Preview
simplescreenrecorder-2023-11-04_12.50.48.mp4