Allow additional hexadecimal color codes in ColorPicker #84442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Nov 4, 2023
|
Needs rebase. |
Calinou
force-pushed
the
colorpicker-allow-more-hex-codes
branch
from
662a110
to
46a94b6
Compare
Rebased and tested again following #85749, it works as expected. |
KoBeWi
reviewed
Jan 5, 2024
Calinou
force-pushed
the
colorpicker-allow-more-hex-codes
branch
from
46a94b6
to
760cc5a
Compare
KoBeWi
reviewed
Jan 8, 2024
KoBeWi
approved these changes
Jan 8, 2024
The following formats are now accepted (leading `#` is optional): - `#1` -> `#111111` - `godotengine#12` -> `#121212` - `godotengine#12345` -> `#11223344` (`5` at the end is discarded) - `#1234567` -> `#123456` (`7` at the end is discarded)
Calinou
force-pushed
the
colorpicker-allow-more-hex-codes
branch
from
760cc5a
to
80a770a
Compare
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following formats are now accepted (leading
#is optional):#1→#111111#12→#121212#12345→#11223344(5at the end is discarded)#1234567→#123456(7at the end is discarded)I've tested named color input and it still works as expected.
Preview
simplescreenrecorder-2023-11-04_11.05.02.mp4