-
-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement export/import functionality for custom input actions #84902
base: master
Are you sure you want to change the base?
Conversation
Please open a proposal when making new features, to gauge the need and popularity of a proposed feature |
Proposal created (I hope it will not be a problem as it is an Issue not the 'discussion' ... there are no other options) |
Update: @Calinou, @AThousandShips - this means green light or should I still wait for approval of proposal #423? |
Proposals don't really get the green light like that, all we really give is "we'd like to see this", it's all down to the PR, the only thing is that a proposal can be turned down due to lack of interest or being incompatible |
a "clear defaults" button to clear all the build in default inputs would also be useful, i often end up deleting them 1 by 1 |
Thank you for this PR! If you want to add more functionality like the clear default button as @MMUTFX2053 suggested, it might be better to move these buttons (Import Actions, Export Actions, Delete Default Actions) under a vertical three dot dropdown menu like in other areas of the editor to show additional options. three_dot_options.mp4 |
@ZycaR i think "restore built-in actions" is more descriptive |
Update: Question: |
I hope the Pull Request is ready for review! Does the editor have unit tests? |
You can add them if you have an idea how to test this for regression. Also make sure to check the CI reports, you have codestyle issues which need to be fixed before the full CI suite can run: https://github.com/godotengine/godot/actions/runs/6937666541/job/18883753525?pr=84902 |
@YuriSizov - builds are green ... finally :) |
I don't know about others, but I personally always toggle the "show built in actions" whenever I start a new project. Since I always add to those default actions. The "Add new action" box is also incredibly large, and the "Add" Button all the way to the right, so I think there is enough space to have and keep the "show built in actions" there as it is right now. What do you think? |
We can keep the switch there if it is desirable. I'll also include it in tree-dot menu to have this options together with new remove/restore built in actions. |
Input Action Map - Import / Export feature
Actions:
Import Custom Actions -> Pick file (previously exported of project.godot file) to import custom actions or merge additional actions into existing set.
Export Custom Actions -> Export user defined actions into text file.
Remove Built-in Action -> This action remove all 'key' events from build in actions.
Restore Built-in Action -> Reset build-in actions to default deadzone (0.5) and 'key' events.
UI Update:
Move Show Built-in Actions into threedot menu.