Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion for TranslationServer #87191

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 14, 2024

Related to #86893, #86753, #86747, #86758, #86764, breathes in #86777, and #86798

This PR adds autocompletion for TranslationServer's get_language_name, get_script_name and get_country_name.

get_language_name get_script_name get_country_name
image image image

I originally was not sure whether or not to do this, since each one of these options has very few characters and there is a lot of them. I then realised it could be nice to know that what you're writing is actually on the list, when using constant Strings?

@Mickeon Mickeon requested a review from a team as a code owner January 14, 2024 20:51
@Mickeon Mickeon force-pushed the autocompletion-TranslationServer branch from 96994bf to e6051a9 Compare January 14, 2024 20:53
@Rubonnek Rubonnek added this to the 4.3 milestone Jan 17, 2024
@Rubonnek Rubonnek added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 17, 2024
@Rubonnek Rubonnek modified the milestones: 4.3, 4.x Jan 17, 2024
@Rubonnek Rubonnek removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 17, 2024
@Mickeon Mickeon force-pushed the autocompletion-TranslationServer branch from e6051a9 to ffd498c Compare February 29, 2024 19:43
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 29, 2024
@akien-mga akien-mga merged commit 0a089e2 into godotengine:master Mar 1, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the autocompletion-TranslationServer branch March 1, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants