Add autocompletion for RenderingServer's global shader methods & has_os_feature
#86798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
autocompletion-rendering-server
branch
from
130b7bc
to
d617111
Compare
clayjohn
reviewed
Jan 5, 2024
Mickeon
force-pushed
the
autocompletion-rendering-server
branch
from
d617111
to
7eae72c
Compare
Mickeon
force-pushed
the
autocompletion-rendering-server
branch
from
7eae72c
to
472e3b3
Compare
|
Updated this PR to cleanse @clayjohn's worries by surrounding the method with TOOLS_ENABLED. |
clayjohn
approved these changes
Jan 8, 2024
akien-mga
approved these changes
Jan 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #86753, #86747, #86758, #86764, and #86777
This PR adds autocompletion to all of RenderingServer's methods that are about global shaders, allowing you to see the available ones right away, instead of having to check the Project Settings every time.
It also features...
has_os_feature()because it's really nice to have a general clue as to what to put in there.