Add autocompletion for InputMap's methods #86764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
autocompletion-inputmap
branch
5 times, most recently
from
19209a5
to
36fd4d0
Compare
|
By the way, the autocompletion should use |
|
You would wish that. And #66481 (for godotengine/godot-proposals#5496) would have it convered across the board. It's outside the scope of this PR, and I for one would rather see them as Strings because I feel like most users shouldn't have to think about it. #66481 has been ready for a year, so... yeah... |
Mickeon
force-pushed
the
autocompletion-inputmap
branch
2 times, most recently
from
de3e201
to
061d5f0
Compare
This was referenced Jan 4, 2024
Mickeon
force-pushed
the
autocompletion-inputmap
branch
from
061d5f0
to
1d513f1
Compare
akien-mga
reviewed
Mar 1, 2024
akien-mga
approved these changes
Mar 1, 2024
Mickeon
force-pushed
the
autocompletion-inputmap
branch
2 times, most recently
from
02f3000
to
6eaf484
Compare
|
Might be worth a rebase, I just noticed this branch is a few thousand commits behind |
|
I have rebased and pushed to remote, but it doesn't feel like GitHub itself is updating properly here. |
Mickeon
force-pushed
the
autocompletion-inputmap
branch
from
6eaf484
to
70b4280
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #86747, #86753 and #86758.
Input already autocompleted actions, but InputMap, which only contains actions, never did.
... The code is copied straight from Input itself.