SCons: Pass optimization flags to the linker too, needed by Emscripten #94109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:buildsystem
cherrypick:3.x
|
Doesn't look like the MSVC linker can use the optimization flags |
I tried to use ChatGPT as a "read tech docs for me and summarize it", but sounds like I wasn't critical enough of its claim that those flags impact MSVC whole-program optimization :P |
akien-mga
force-pushed
the
scons-linker-optflags
branch
from
ddc442d
to
7d70862
Compare
Repiteo
approved these changes
Jul 9, 2024
|
Just pointing out the regression in #94725 for myself, so I don't cherry-pick this change before we've solved that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing with various compilers to confirm that it doesn't have a negative impact / cause errors to pass those to the linker for MSVC, GCC, and Clang.
From a quick test with GCC, both with and without LTO, it didn't seem to make a difference in my tests.