Merge pull request #3683 from gofiber/codex/2025-08-13-15-47-17

🧹 chore: delay routing error creation

Author: gaby

client/core_test.go

@@ -7,10 +7,11 @@ import (
 	"testing"
 	"time"
 
-	"github.com/gofiber/fiber/v3"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"github.com/valyala/fasthttp/fasthttputil"
+
+	"github.com/gofiber/fiber/v3"
 )
 
 func Test_AddMissing_Port(t *testing.T) {
@@ -168,7 +169,7 @@ func Test_Execute(t *testing.T) {
 
 		resp, err := core.execute(context.Background(), client, req)
 		require.NoError(t, err)
-		require.Equal(t, "Cannot GET /", string(resp.RawResponse.Body()))
+		require.Equal(t, "Not Found", string(resp.RawResponse.Body()))
 	})
 
 	t.Run("add user response hooks", func(t *testing.T) {
@@ -185,7 +186,7 @@ func Test_Execute(t *testing.T) {
 
 		resp, err := core.execute(context.Background(), client, req)
 		require.NoError(t, err)
-		require.Equal(t, "Cannot GET /", string(resp.RawResponse.Body()))
+		require.Equal(t, "Not Found", string(resp.RawResponse.Body()))
 	})
 
 	t.Run("no timeout", func(t *testing.T) {

docs/guide/routing.md

@@ -128,7 +128,7 @@ In addition, several parameters in a row and several unnamed parameter character
 app.Get("/:sign:param", handler)
 
 // GET /api-v1
-// Params: "name" -> "v1" 
+// Params: "name" -> "v1"
 app.Get("/api-:name", handler)
 
 // GET /customer/v1/cart/proxy
@@ -180,7 +180,7 @@ app.Get("/:test<min(5)>", func(c fiber.Ctx) error {
 // 12
 
 // curl -X GET http://localhost:3000/1
-// Cannot GET /1
+// Not Found
 ```
 
 </TabItem>
@@ -194,10 +194,10 @@ app.Get("/:test<min(100);maxLen(5)>", func(c fiber.Ctx) error {
 })
 
 // curl -X GET http://localhost:3000/120000
-// Cannot GET /120000
+// Not Found
 
 // curl -X GET http://localhost:3000/1
-// Cannot GET /1
+// Not Found
 
 // curl -X GET http://localhost:3000/250
 // 250
@@ -214,10 +214,10 @@ app.Get(`/:date<regex(\d{4}-\d{2}-\d{2})>`, func(c fiber.Ctx) error {
 })
 
 // curl -X GET http://localhost:3000/125
-// Cannot GET /125
+// Not Found
 
 // curl -X GET http://localhost:3000/test
-// Cannot GET /test
+// Not Found
 
 // curl -X GET http://localhost:3000/2022-08-27
 // 2022-08-27
@@ -243,7 +243,7 @@ app.Get("/:test<int>?", func(c fiber.Ctx) error {
 // curl -X GET http://localhost:3000/
 //
 // curl -X GET http://localhost:3000/7.0
-// Cannot GET /7.0
+// Not Found
 ```
 
 #### Custom Constraint

hooks_test.go

@@ -6,10 +6,11 @@ import (
 	"testing"
 	"time"
 
-	"github.com/gofiber/fiber/v3/log"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"github.com/valyala/bytebufferpool"
+
+	"github.com/gofiber/fiber/v3/log"
 )
 
 const testMountPath = "/api"
@@ -418,7 +419,7 @@ func Test_executeOnListenHooks_Error(t *testing.T) {
 		return errors.New("listen error")
 	})
 
-	err := app.hooks.executeOnListenHooks(ListenData{Host: "127.0.0.1", Port: "80"})
+	err := app.hooks.executeOnListenHooks(ListenData{Host: "127.0.0.1", Port: "0"})
 	require.EqualError(t, err, "listen error")
 }
 

middleware/keyauth/keyauth_test.go

@@ -10,9 +10,10 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/gofiber/fiber/v3"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/gofiber/fiber/v3"
 )
 
 const CorrectKey = "specials: !$%,.#\"!?~`<>@$^*(){}[]|/\\123"
@@ -166,6 +167,7 @@ func Test_AuthSources(t *testing.T) {
 				require.NoError(t, err, test.description)
 
 				body, err := io.ReadAll(res.Body)
+
 				require.NoError(t, err)
 				errClose := res.Body.Close()
 				require.NoError(t, errClose)
@@ -191,7 +193,7 @@ func Test_AuthSources(t *testing.T) {
 
 				if authSource == paramExtractorName && testKey == "" {
 					expectedCode = 404
-					expectedBody = "Cannot GET /"
+					expectedBody = "Not Found"
 				}
 				require.Equal(t, expectedCode, res.StatusCode, test.description)
 				require.Equal(t, expectedBody, string(body), test.description)

middleware/logger/logger_test.go

@@ -18,12 +18,13 @@ import (
 	"testing"
 	"time"
 
-	"github.com/gofiber/fiber/v3"
-	fiberlog "github.com/gofiber/fiber/v3/log"
-	"github.com/gofiber/fiber/v3/middleware/requestid"
 	"github.com/stretchr/testify/require"
 	"github.com/valyala/bytebufferpool"
 	"github.com/valyala/fasthttp"
+
+	"github.com/gofiber/fiber/v3"
+	fiberlog "github.com/gofiber/fiber/v3/log"
+	"github.com/gofiber/fiber/v3/middleware/requestid"
 )
 
 const (
@@ -468,7 +469,7 @@ func Test_Logger_All(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, fiber.StatusNotFound, resp.StatusCode)
 
-	expected := fmt.Sprintf("%dHost=example.comhttpHTTP/1.10.0.0.0example.com/?foo=bar/%s%s%s%s%s%s%s%s%sCannot GET /", os.Getpid(), colors.Black, colors.Red, colors.Green, colors.Yellow, colors.Blue, colors.Magenta, colors.Cyan, colors.White, colors.Reset)
+	expected := fmt.Sprintf("%dHost=example.comhttpHTTP/1.10.0.0.0example.com/?foo=bar/%s%s%s%s%s%s%s%s%sNot Found", os.Getpid(), colors.Black, colors.Red, colors.Green, colors.Yellow, colors.Blue, colors.Magenta, colors.Cyan, colors.White, colors.Reset)
 	require.Equal(t, expected, buf.String())
 }
 
@@ -1039,7 +1040,7 @@ func Test_Logger_ForceColors(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, fiber.StatusNotFound, resp.StatusCode)
 
-	expected := fmt.Sprintf("0.0.0.0%s404%s%sGET%s/%sCannot GET /%s\n", colors.Yellow, colors.Reset, colors.Cyan, colors.Reset, colors.Red, colors.Reset)
+	expected := fmt.Sprintf("0.0.0.0%s404%s%sGET%s/%sNot Found%s\n", colors.Yellow, colors.Reset, colors.Cyan, colors.Reset, colors.Red, colors.Reset)
 	require.Equal(t, expected, buf.String())
 }
 

middleware/static/static_test.go

@@ -59,7 +59,7 @@ func Test_Static_Index_Default(t *testing.T) {
 
 	body, err = io.ReadAll(resp.Body)
 	require.NoError(t, err)
-	require.Equal(t, "Cannot GET /not-found", string(body))
+	require.Equal(t, "Not Found", string(body))
 }
 
 // go test -run Test_Static_Index
@@ -178,7 +178,7 @@ func Test_Static_Disable_Cache(t *testing.T) {
 
 	body, err = io.ReadAll(resp.Body)
 	require.NoError(t, err)
-	require.Equal(t, "Cannot GET /test.txt", string(body))
+	require.Equal(t, "Not Found", string(body))
 }
 
 func Test_Static_NotFoundHandler(t *testing.T) {
@@ -962,13 +962,13 @@ func Test_Static_PathTraversal(t *testing.T) {
 		body, err := io.ReadAll(resp.Body)
 		require.NoError(t, err)
 
-		// If we got a 404, we expect the "Cannot GET" message because that's how fiber handles NotFound by default.
+		// If we got a 404, we expect the "Not Found" message because that's how fiber handles NotFound by default.
 		if status == 404 {
-			require.Contains(t, string(body), "Cannot GET",
-				"Blocked traversal should have a Cannot GET message for %s", path)
+			require.Contains(t, string(body), "Not Found",
+				"Blocked traversal should have a \"Not Found\" message for %s", path)
 		} else {
 			require.Contains(t, string(body), "Are you a hacker?",
-				"Blocked traversal should have a Cannot GET message for %s", path)
+				"Blocked traversal should have a \"Not Found\" message for %s", path)
 		}
 	}
 
@@ -1066,15 +1066,15 @@ func Test_Static_PathTraversal_WindowsOnly(t *testing.T) {
 		require.Containsf(t, []int{400, 404}, status,
 			"Status code for path traversal %s should be 400 or 404, got %d", path, status)
 
-		// If it's a 404, we expect a "Cannot GET" message
+		// If it's a 404, we expect a "Not Found" message
 		if status == 404 {
 			respBody, err := io.ReadAll(resp.Body)
 			require.NoError(t, err)
-			require.Contains(t, string(respBody), "Cannot GET",
-				"Blocked traversal should have a 'Cannot GET' message for %s", path)
+			require.Contains(t, string(respBody), "Not Found",
+				"Blocked traversal should have a \"Not Found\" message for %s", path)
 		} else {
 			require.Contains(t, string(body), "Are you a hacker?",
-				"Blocked traversal should have a Cannot GET message for %s", path)
+				"Blocked traversal should have a \"Not Found\" message for %s", path)
 		}
 	}
 

router.go

@@ -7,7 +7,6 @@ package fiber
 import (
 	"bytes"
 	"fmt"
-	"html"
 	"slices"
 	"sync/atomic"
 
@@ -117,7 +116,6 @@ func (app *App) next(c *DefaultCtx) (bool, error) {
 	lenr := len(tree) - 1
 
 	indexRoute := c.indexRoute
-	var err error
 
 	// Loop over the route stack starting from previous index
 	for indexRoute < lenr {
@@ -153,12 +151,10 @@ func (app *App) next(c *DefaultCtx) (bool, error) {
 	}
 
 	// If c.Next() does not match, return 404
-	err = NewError(StatusNotFound, "Cannot "+c.Method()+" "+html.EscapeString(c.getPathOriginal()))
-
 	// If no match, scan stack again if other methods match the request
 	// Moved from app.handler because middleware may break the route chain
 	if c.matched {
-		return false, err
+		return false, ErrNotFound
 	}
 
 	exists := false
@@ -201,9 +197,9 @@ func (app *App) next(c *DefaultCtx) (bool, error) {
 		c.indexRoute = indexRoute
 	}
 	if exists {
-		err = ErrMethodNotAllowed
+		return false, ErrMethodNotAllowed
 	}
-	return false, err
+	return false, ErrNotFound
 }
 
 func (app *App) nextCustom(c CustomCtx) (bool, error) {
@@ -217,7 +213,6 @@ func (app *App) nextCustom(c CustomCtx) (bool, error) {
 	lenr := len(tree) - 1
 
 	indexRoute := c.getIndexRoute()
-	var err error
 
 	// Loop over the route stack starting from previous index
 	for indexRoute < lenr {
@@ -251,12 +246,10 @@ func (app *App) nextCustom(c CustomCtx) (bool, error) {
 	}
 
 	// If c.Next() does not match, return 404
-	err = NewError(StatusNotFound, "Cannot "+c.Method()+" "+html.EscapeString(c.getPathOriginal()))
-
 	// If no match, scan stack again if other methods match the request
 	// Moved from app.handler because middleware may break the route chain
 	if c.getMatched() {
-		return false, err
+		return false, ErrNotFound
 	}
 
 	exists := false
@@ -299,9 +292,9 @@ func (app *App) nextCustom(c CustomCtx) (bool, error) {
 		c.setIndexRoute(indexRoute)
 	}
 	if exists {
-		err = ErrMethodNotAllowed
+		return false, ErrMethodNotAllowed
 	}
-	return false, err
+	return false, ErrNotFound
 }
 
 func (app *App) requestHandler(rctx *fasthttp.RequestCtx) {

router_test.go

@@ -395,7 +395,7 @@ func Test_Router_NotFound(t *testing.T) {
 	appHandler(c)
 
 	require.Equal(t, 404, c.Response.StatusCode())
-	require.Equal(t, "Cannot DELETE /this/route/does/not/exist", string(c.Response.Body()))
+	require.Equal(t, "Not Found", string(c.Response.Body()))
 }
 
 func Test_Router_NotFound_HTML_Inject(t *testing.T) {
@@ -413,7 +413,7 @@ func Test_Router_NotFound_HTML_Inject(t *testing.T) {
 	appHandler(c)
 
 	require.Equal(t, 404, c.Response.StatusCode())
-	require.Equal(t, "Cannot DELETE /does/not/exist<script>alert('foo');</script>", string(c.Response.Body()))
+	require.Equal(t, "Not Found", string(c.Response.Body()))
 }
 
 func registerTreeManipulationRoutes(app *App, middleware ...func(Ctx) error) {
@@ -911,6 +911,7 @@ func Benchmark_App_MethodNotAllowed(b *testing.B) {
 
 // go test -v ./... -run=^$ -bench=Benchmark_Router_NotFound -benchmem -count=4
 func Benchmark_Router_NotFound(b *testing.B) {
+	b.ReportAllocs()
 	app := New()
 	app.Use(func(c Ctx) error {
 		return c.Next()
@@ -926,7 +927,7 @@ func Benchmark_Router_NotFound(b *testing.B) {
 		appHandler(c)
 	}
 	require.Equal(b, 404, c.Response.StatusCode())
-	require.Equal(b, "Cannot DELETE /this/route/does/not/exist", string(c.Response.Body()))
+	require.Equal(b, "Not Found", string(c.Response.Body()))
 }
 
 // go test -v ./... -run=^$ -bench=Benchmark_Router_Handler -benchmem -count=4