Minor grammatical fix for Disable Registration feature#87
Merged
Conversation
Member
|
Thanks for your PR, I made a little comment on file change page. |
Member
There was a problem hiding this comment.
This change will make incompatible which newer version cannot recognized the old configuration...But changes on code(in .go files) itself would be fine.
Member
|
Anyway, I'll merge this and make little changes locally. Thanks again! |
unknwon
added a commit
that referenced
this pull request
Apr 22, 2014
Minor grammatical fix for Disable Registration feature
strk
added a commit
to strk/gogs
that referenced
this pull request
Nov 7, 2016
Still use GOGS_WORK_DIR and GOGS_CUSTOM env variables as a fallback if the equivalent GITEA_* are not set, warning user about the need for change. Also change "gogs" to "gitea" in webhook type name Closes gogs#87
strk
added a commit
to strk/gogs
that referenced
this pull request
Nov 7, 2016
Still use GOGS_WORK_DIR and GOGS_CUSTOM env variables as a fallback if the equivalent GITEA_* are not set, warning user about the need for change. Also change "gogs" to "gitea" in webhook type name Closes gogs#87
strk
added a commit
to strk/gogs
that referenced
this pull request
Nov 7, 2016
Still use GOGS_WORK_DIR and GOGS_CUSTOM env variables as a fallback if the equivalent GITEA_* are not set, warning user about the need for change. Does not change "gogs" to "gitea" in webhook type name Because "gogs" hook type is part of the API (routes) and used in templates... Closes gogs#87
richmahn
pushed a commit
to richmahn/gogs
that referenced
this pull request
Nov 21, 2016
richmahn
pushed a commit
to richmahn/gogs
that referenced
this pull request
Nov 21, 2016
richmahn
pushed a commit
to richmahn/gogs
that referenced
this pull request
Nov 21, 2016
richmahn
added a commit
to richmahn/gogs
that referenced
this pull request
Nov 21, 2016
richmahn
added a commit
to richmahn/gogs
that referenced
this pull request
Nov 23, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor readability spelling / grammar fix to the "disable registration" feature.
Happy to discuss!