Fixes security issue #3110 #3136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, that's weird. Doesn't that mean that there is an empty AccessToken in the database ? I'm pretty sure that's not normal. |
|
No. It's the way, how xorm queries the db. If there is no query (or an empty query, because sha is empty), it returns the first entry in the table. |
|
Looks good to me 👍 |
|
Seems having conflict? |
|
@unknwon fixed |
|
It would be even better to cleanup into 1 commit :D |
|
Thanks! |
ethantkoenig
pushed a commit
to ethantkoenig/gogs
that referenced
this pull request
Feb 6, 2018
* new issue mention * Mention completion on new issue and view issue page. * Code format. * Require tribute in pull request page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, make sure you are targeting the
developbranch!More instructions about contributing with Gogs code can be found here:
https://github.com/gogits/gogs/wiki/Contributing-Code
Fixes security issue #3110 by checking if sha token is empty and returning error in this case