Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Add CORS support to all endpoints#171

Merged
mattjohnsonpint merged 3 commits intomainfrom
mjp/cors
May 3, 2024
Merged

Add CORS support to all endpoints#171
mattjohnsonpint merged 3 commits intomainfrom
mjp/cors

Conversation

@mattjohnsonpint
Copy link
Contributor

Fixes HYP-1137

@mattjohnsonpint mattjohnsonpint requested a review from a team May 3, 2024 19:30
@linear
Copy link

linear bot commented May 3, 2024

HYP-1137 Add Access-Control-Allow-Origin header to /graphql endpoint

Use case: we want to show a graphiql interface on the console UI so that users can easily query their /graphql endpoint without having to leave and go to postman.

Currently, we're hitting a cors error from the client :

image.png

We can only set one value for the Access-Control-Allow-Origin. We might want to default it to the catch-all "*" for now to test and make this something user configurable down the road.

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) May 3, 2024 19:34
@mattjohnsonpint mattjohnsonpint merged commit 639b00d into main May 3, 2024
@mattjohnsonpint mattjohnsonpint deleted the mjp/cors branch May 3, 2024 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants