Skip to content

Conversation

@pellared
Copy link
Member

@pellared pellared commented Feb 28, 2021

#115 follow-up

kudos for @jizusun

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #116 (971f6e9) into main (4654079) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files           1        1           
  Lines           2        2           
=======================================
  Hits            1        1           
  Misses          1        1           
Flag Coverage Δ
Linux 50.00% <ø> (ø)
Windows 50.00% <ø> (ø)
macOS 50.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4654079...971f6e9. Read the comment docs.

@jizusun
Copy link
Contributor

jizusun commented Feb 28, 2021

#115 follow-up

kudos for @jizusun

Oh thank you sir ♥️

@jizusun
Copy link
Contributor

jizusun commented Feb 28, 2021

#115 follow-up

kudos for @jizusun

Oh please think twice.

I'm not sure what will happen, when our downstreams pull and merge from us but forget to rename their default branch to main.

Maybe this will break our downstream.

@pellared pellared changed the title Remove master branch Use main branch Feb 28, 2021
@pellared pellared merged commit 3d6cbcb into main Feb 28, 2021
@pellared pellared deleted the remove-master-branch branch February 28, 2021 13:05
@pellared
Copy link
Member Author

#115 follow-up
kudos for @jizusun

Oh please think twice.

I'm not sure what will happen, when our downstreams pull and merge from us but forget to rename their default branch to main.

Maybe this will break our downstream.

Bagdes will not work. Moreover build and codeql workflows will not work as expected. However changing the default branch even afterwards will fix it. It is not possible to support two main branches at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants