Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Conversation

@jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Aug 31, 2017

What does this do / why do we need it?

Just a bit of error cleanup.

  • Leverage implicit ProjectIdentifier.String()
  • Swap in errors.Wrap... when tacking the error on as the last argument to Errorf

@darkowlzz
Copy link
Collaborator

Can we also replace all the fmt.Errorf() with errors.Wrapf()?
Like in
https://github.com/golang/dep/blob/master/cmd/dep/status.go#L380
https://github.com/golang/dep/blob/master/internal/gps/source_manager.go#L176
https://github.com/golang/dep/blob/master/internal/gps/source_manager.go#L223

Copy link
Collaborator

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carolynvs carolynvs merged commit da061e9 into golang:master Aug 31, 2017
@carolynvs
Copy link
Collaborator

@darkowlzz Shoot, sorry I just realized that you actually asked for more changes... 😊

@jmank88 jmank88 deleted the errs branch August 31, 2017 23:23
This was referenced Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants