This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps: source cache: adding multiCache #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR adds
type multiCache struct, which is asingleSourceCachethat manages two cache levels, ephemeral in-memory and persistent on-disk. It is currently only tested, and will be integrated later.This is a simple implementation. There is room for optimization which can be explored later when integrating (e.g. I've implemented async background disk writes on my WIP branch, which pairs nicely with batch Bolt updates, especially now that we're using a single file).
Which issue(s) does this PR fix?
Towards #431