This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Introduce IgnoredRuleset #1268
Merged
Introduce IgnoredRuleset #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a single type for handling both literal and wildcard ignore patterns, allowing us to tighten up a few interfaces.
The most crucial piece is fixing the hasher to make its prefix checks without the wildcard suffix for the purpose of determining whether the ignore affects the root project; otherwise, wildcards on the root of the current project (why would you do this?) would be erroneously included in hash inputs.
This also adds `dep hash-inputs` output to both of the harness tests, so that it's easier for developers to keep track of the expected output in these cases.
Collaborator
|
Went through once and got the idea. Makes sense 👍 much better I'll go through one more time tomorrow, if you don't merge it by then 😊 |
It's clearer just to use the string literal in this case.
Member
Author
|
ok, putting this in so that we can get to the bits we care about, heh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This introduces a new type,
IgnoredRuleset, which encapsulates both literal and wildcard ignores. It is swapped in in place ofmap[string]boolwherever we'd been using that previously.What should your reviewer look out for in this PR?
Correctness issues in the implementation itself, or sloppiness in the conversion.
Which issue(s) does this PR fix?
fixes #1264