Skip to content

Conversation

@shalimski
Copy link
Contributor

No description provided.

@gopherbot
Copy link

This PR (HEAD: dae6d6b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/example/+/550196.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1 Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Robert Griesemer:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jonathan Amsterdam:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/550196.
After addressing review feedback, remember to publish your drafts!

@shalimski shalimski changed the title fixed word duplication slog-handler-guide/README.md: fix word duplication Feb 5, 2024
@gopherbot
Copy link

This PR (HEAD: 2052832) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/example/+/550196.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot pushed a commit that referenced this pull request Feb 5, 2024
Change-Id: Id17b4acd73e237813292a63112b30e915d652bd4
GitHub-Last-Rev: 2052832
GitHub-Pull-Request: #29
Reviewed-on: https://go-review.googlesource.com/c/example/+/550196
Reviewed-by: qiulaidongfeng <2645477756@qq.com>
Run-TryBot: qiulaidongfeng <2645477756@qq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/550196 has been merged.

@gopherbot gopherbot closed this Feb 5, 2024
@shalimski shalimski deleted the patch-1 branch May 1, 2024 13:13
astro0099 pushed a commit to astro0099/golang-example that referenced this pull request Nov 20, 2024
Change-Id: Id17b4acd73e237813292a63112b30e915d652bd4
GitHub-Last-Rev: 2052832a0d60d4b417f94e25fcb6802efd2aaf39
GitHub-Pull-Request: golang/example#29
Reviewed-on: https://go-review.googlesource.com/c/example/+/550196
Reviewed-by: qiulaidongfeng <2645477756@qq.com>
Run-TryBot: qiulaidongfeng <2645477756@qq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
Dreamcatcher600 added a commit to Dreamcatcher600/GoLang-project that referenced this pull request Jan 27, 2025
Change-Id: Id17b4acd73e237813292a63112b30e915d652bd4
GitHub-Last-Rev: 2052832a0d60d4b417f94e25fcb6802efd2aaf39
GitHub-Pull-Request: golang/example#29
Reviewed-on: https://go-review.googlesource.com/c/example/+/550196
Reviewed-by: qiulaidongfeng <2645477756@qq.com>
Run-TryBot: qiulaidongfeng <2645477756@qq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
sweetdream-001 added a commit to sweetdream-001/go-example that referenced this pull request Feb 14, 2025
Change-Id: Id17b4acd73e237813292a63112b30e915d652bd4
GitHub-Last-Rev: 2052832a0d60d4b417f94e25fcb6802efd2aaf39
GitHub-Pull-Request: golang/example#29
Reviewed-on: https://go-review.googlesource.com/c/example/+/550196
Reviewed-by: qiulaidongfeng <2645477756@qq.com>
Run-TryBot: qiulaidongfeng <2645477756@qq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
passionate-dev219 added a commit to passionate-dev219/gopher-golang-project that referenced this pull request May 7, 2025
Change-Id: Id17b4acd73e237813292a63112b30e915d652bd4
GitHub-Last-Rev: 2052832a0d60d4b417f94e25fcb6802efd2aaf39
GitHub-Pull-Request: golang/example#29
Reviewed-on: https://go-review.googlesource.com/c/example/+/550196
Reviewed-by: qiulaidongfeng <2645477756@qq.com>
Run-TryBot: qiulaidongfeng <2645477756@qq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants