Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/net/http2: client should drop connection specific headers #15085
Please answer these questions before submitting your issue. Thanks!
net/http2 errors when adding a connection-specific header to client requests.
For example, adding a Keep-Alive header to an HTTP request (as the Google certificate-transparency client does) and have it go over an HTTP/2 connection.
Per Section 184.108.40.206 of the HTTP/2 spec, connection-specific headers are to be dropped by HTTP/2 clients.
A working GET request to an HTTP/2 server that returns a 200
A 400 Bad Request response from the HTTP/2 server.
This was discovered in google/certificate-transparency#1136
Adds Keep-Alive to the list of ignored headers in encodeHeaders as required in the HTTP/2 spec (section 220.127.116.11) and adds a test to check this. Fixes golang/go#15085 Change-Id: Ie4624680c5de1f13eb94fa58a2d5d67a02634df3 Reviewed-on: https://go-review.googlesource.com/21482 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Run-TryBot: Brad Fitzpatrick <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org>