Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: new empty milestones are not detected #25744

FiloSottile opened this issue Jun 6, 2018 · 3 comments

x/build/maintner: new empty milestones are not detected #25744

FiloSottile opened this issue Jun 6, 2018 · 3 comments


Copy link

@FiloSottile FiloSottile commented Jun 6, 2018

A new milestone with no issues does not show up in the corpus.

(Also, don't mind me while I use this issue to prime the corpus.)

@gopherbot gopherbot added this to the Unreleased milestone Jun 6, 2018
@FiloSottile FiloSottile modified the milestones: Unreleased, Go1.10.4, Go1.9.8 Jun 6, 2018
Copy link

@dmitshur dmitshur commented Sep 7, 2018

I ran into what I suspect to be a related issue while doing #26949.

A newly added GitHub repository with zero issues does not show up in the corpus. As soon as I created the first Pull Request (which counts as an issue), the repository showed up:

1. added "dl" to whitelist (CL x) and redeployed maintnerd
2. corpus.GitHub().Repo("golang", "dl") // nil
3. created first issue/PR in the repo
4. corpus.GitHub().Repo("golang", "dl") // non-nil

(Thanks @FiloSottile for reporting this issue; if I hadn't seen it, it would've been harder for me to debug what went wrong.)

To test this, I used maintserve. I also ran the following snippet:

package main

import (


func main() {
	corpus, err := godata.Get(context.Background())
	if err != nil {
	num := make(map[string]int)
	for _, name := range []string{"example", "dl"} {
		repo := corpus.GitHub().Repo("golang", name)
		if repo == nil {
		err = repo.ForeachIssue(func(gi *maintner.GitHubIssue) error {
			return nil
		if err != nil {

Before first PR:


After first PR:

map[example:11 dl:1]

Edit: That said, I don't think this is necessarily a bad behavior that must be changed. Perhaps the right fix is documentation. I'd need to think through the trade-offs before making a decision.

@katiehockman katiehockman modified the milestones: Unreleased, Go1.11.2 Oct 1, 2018
Copy link

@katiehockman katiehockman commented Oct 2, 2018

After going through the latest Go release, I think this is indeed a bug. If a new, empty milestone is not picked up by the corpus, then the new milestone for the next release will be ignored. The current code will then require that some random issue is added to this future milestone in order to be picked up and allow the release to proceed. I also used this issue to prime the corpus as @FiloSottile did, but that feels like a bit of a hack.

@FiloSottile FiloSottile modified the milestones: Go1.10.8, Go1.11.5, Unreleased Dec 14, 2018
@julieqiu julieqiu modified the milestones: Unreleased, Go1.11.6, Go1.10.9 Jan 23, 2019
@dmitshur dmitshur modified the milestones: Unreleased, Go1.12.7, Go1.11.12 Jun 7, 2019
@dmitshur dmitshur removed this from the Go1.11.12 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants