x/build: add at least one 32-bit longtest builder #29641
Closed
Milestone
Comments
|
/cc @bcmills |
|
Change https://golang.org/cl/202479 mentions this issue: |
codebien
added a commit
to codebien/build
that referenced
this issue
Nov 13, 2019
Fixes golang/go#29641 Fixes golang/go#26529 Change-Id: I5ab3aa443276ab36b866d7fabc1d78a82b34cb64 Reviewed-on: https://go-review.googlesource.com/c/build/+/202479 Reviewed-by: Bryan C. Mills <bcmills@google.com>
|
Change https://golang.org/cl/234520 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
May 19, 2020
The linux-386-longtest builder was added in CL 202479 with these environment variables unset, which caused the builder to run long tests for the linux/amd64 pair. Setting these to "386" makes the builder run long tests for linux/386 instead, which increases 32-bit test coverage as originally intended. For golang/go#29641. Change-Id: I9fbebc9e37e5f27f21d840d86006192daeaee8c5 Reviewed-on: https://go-review.googlesource.com/c/build/+/234520 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>
|
Change https://golang.org/cl/240512 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Jul 1, 2020
Both golang.org/x/exp and golang.org/x/mobile are experimental, and do not support the linux/386 port. Stop running post-submit longtest builds on it. If support for linux/386 is added, tests should start to pass and the builder can be re-enabled then. It appears to have been enabled previously due to a misconfiguration rather than on purpose. Fixes golang/go#39156. For golang/go#29641. For golang/go#11811. Change-Id: I12437880380b9015f6ed9d584db11717f4f024e6 Reviewed-on: https://go-review.googlesource.com/c/build/+/240512 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the only builder that runs ~every test is the
linux-amd64-longtestbuilder. It's linux, and it's 64 bit.There's already an issue for a different OS longtest builder (windows: #26529); but having a 32-bit longtest builder would also be useful. See for example #29555: the
archive/ziptest suite was broken on 32-bit archs and nobody noticed because the bad tests are skipped on short so currently they're not run on any builder.Filing this as a remainder.
The text was updated successfully, but these errors were encountered: