Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: support builders that only run on subrepos #30779

Open
bradfitz opened this issue Mar 12, 2019 · 4 comments

Comments

@bradfitz
Copy link
Member

commented Mar 12, 2019

It's currently not possible to configure a builder that only builds a subrepo(s) and not the "go" repo.

This is affecting linux-amd64-androidemu and darwin-amd64-wikofever which aren't building the mobile repo currently, despite being configured to do so.

Two reasons why they aren't:

  • subrepos always wait for a make.bash snapshot (this should be conditional on "go" being configured to even run for that repo)
  • because https://build.golang.org/ never populates the subrepo tables' columns with a builder name if it doesn't also show up in the top ("go") table. And the coordinator uses a json version of that same page (https://build.golang.org/?mode=json) to find work to do.

For the first, it should also be possible to say that a given builder can also use a built make.bash from a different builder. e.g. linux-amd64-androidemu can use a built make.bash tarball from linux-amd64.

/cc @eliasnaur @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Mar 12, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Mar 12, 2019

Change https://golang.org/cl/167197 mentions this issue: dashboard: add some more mobile tests

@eliasnaur

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Perhaps it's easier if the builder is allowed to build "go" for snapshots but not run std tests? I don't know if your second point is also solved then.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

But then it's more spammy width in the build.golang.org top table.

gopherbot pushed a commit to golang/build that referenced this issue Mar 12, 2019
dashboard: add some more mobile tests
They were already passing it turns out, but let's add these lines
specifically anyway.

Updates golang/go#30779

Change-Id: I00e0d3555f06b00098f63fc31bee58fd516c8a66
Reviewed-on: https://go-review.googlesource.com/c/build/+/167197
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Elias Naur <mail@eliasnaur.com>

@bcmills bcmills added the NeedsFix label Apr 12, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Apr 16, 2019

Change https://golang.org/cl/170863 mentions this issue: cmd/gopherbot: CC triaged issues to owners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.