Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add x/tools trybot for main Go repository #34348

Open
dmitshur opened this issue Sep 17, 2019 · 0 comments

Comments

@dmitshur
Copy link
Member

commented Sep 17, 2019

As @jayconrod suggested in #34321 (comment), I think we should add an x/tools trybot builder for the main Go repository. It would check whether x/tools tests on master branch pass with the Go CL being tested. We can use linux-amd64 builder type since it's quick and least expensive.

The Go standard library ships with many packages such as go/parser, go/types, and others. The x/tools repository has many tests that provide additional test coverage.

Trybots for the main Go repository already take 5-10 minutes to run, while the x/tools tests take less than 5 minutes, so it wouldn't slow anything down, just provide more test coverage.

/cc @bradfitz @andybons @toothrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.