Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/env/android-amd64-emu: fix and rebuild image after addition of ANDROID_SDK_ROOT #41578

Open
dmitshur opened this issue Sep 23, 2020 · 4 comments
Open

x/build/env/android-amd64-emu: fix and rebuild image after addition of ANDROID_SDK_ROOT #41578

dmitshur opened this issue Sep 23, 2020 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 23, 2020 •
edited
Loading

In order to unblock CL 244057 (which fixes #39945), we need to rebuild the android-amd64-emu builder image given that CL 247357 has been submitted.

Doing so needs some fixes because a (Debian) package became unavailable due to a security issue. Copied from a CL comment:

I tried building the new image, but ran into problems.

The openjdk-8-jdk package is no longer available in debian buster (search results suggest because of a security problem). I tried using openjdk-11-jdk instead, but then one of the sdkmanager invocations ran into a java.lang.NoClassDefFoundError exception. Maybe we should update to a newer Android SDK.

This is the tracking issue.

/cc @toothrot @cagedmantis @andybons @hyangah @eliasnaur
@dmitshur dmitshur added help wanted Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 23, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 23, 2020
@eliasnaur
Copy link
Contributor

AFAIK, even the newest Android SDK requires Java 8 for sdkmanager. What I did for Gio's CI is to use the Azul's JDK 8. See https://git.sr.ht/~eliasnaur/gio/tree/master/.builds/linux.yml#L60.

@eliasnaur
Copy link
Contributor

I forgot https://go-review.googlesource.com/c/build/+/235098 which is an unmerged attempt to update the android emulator Docker image. It includes the ANDROID_SDK_ROOT rename.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/235098 mentions this issue: env/android-amd64-emu: upgrade NDK to version 21.1.6352462

@hajimehoshi
Copy link
Member

What's going on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@hajimehoshi @eliasnaur @dmitshur @gopherbot