Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/env/android-amd64-emu: fix and rebuild image after addition of ANDROID_SDK_ROOT #41578

Open
dmitshur opened this issue Sep 23, 2020 · 4 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Sep 23, 2020

In order to unblock CL 244057 (which fixes #39945), we need to rebuild the android-amd64-emu builder image given that CL 247357 has been submitted.

Doing so needs some fixes because a (Debian) package became unavailable due to a security issue. Copied from a CL comment:

I tried building the new image, but ran into problems.

The openjdk-8-jdk package is no longer available in debian buster (search results suggest because of a security problem). I tried using openjdk-11-jdk instead, but then one of the sdkmanager invocations ran into a java.lang.NoClassDefFoundError exception. Maybe we should update to a newer Android SDK.

This is the tracking issue.

/cc @toothrot @cagedmantis @andybons @hyangah @eliasnaur

@eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented Sep 23, 2020

AFAIK, even the newest Android SDK requires Java 8 for sdkmanager. What I did for Gio's CI is to use the Azul's JDK 8. See https://git.sr.ht/~eliasnaur/gio/tree/master/.builds/linux.yml#L60.

Loading

@eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented Sep 28, 2020

I forgot https://go-review.googlesource.com/c/build/+/235098 which is an unmerged attempt to update the android emulator Docker image. It includes the ANDROID_SDK_ROOT rename.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 23, 2020

Change https://golang.org/cl/235098 mentions this issue: env/android-amd64-emu: upgrade NDK to version 21.1.6352462

Loading

@hajimehoshi
Copy link
Member

@hajimehoshi hajimehoshi commented Feb 8, 2021

What's going on this?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants