Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress/gzip: possible performance regression vs 1.0.3 #5166

Closed
davecheney opened this issue Mar 31, 2013 · 5 comments

Comments

Projects
None yet
4 participants
@davecheney
Copy link
Contributor

commented Mar 31, 2013

What steps will reproduce the problem?
1. git clone https://github.com/davecheney/autobench
2. cd autobench
3. make bench

# autobench is a small harness for running the Go 1.1 go1 tests against go 1.0.3 and tip.

What is the expected output? What do you see instead?

On linux/amd64 several people have reported Gzip encode has increased slightly

BenchmarkGzip                     472108600    486750544   +3.10%

Please use labels and text to provide additional information.
@davecheney

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2013

Comment 1:

No performance regression is visible in the same proportion on 386 or arm (see sample
results in the autobench repository)
@robpike

This comment has been minimized.

Copy link
Contributor

commented May 18, 2013

Comment 2:

Labels changed: added go1.2maybe, removed go1.1maybe.

@davecheney

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2013

Comment 3:

Labels changed: added priority-later, performance, removed priority-triage.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2013

Comment 4:

Labels changed: added feature.

@robpike

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2013

Comment 5:

Not worth worrying about. Reopen if you disagree.

Status changed to WontFix.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015

@rsc rsc removed the go1.2maybe label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.