Skip to content

net/http: TestServerShutdownStateNew is flaky #26233

@mvdan

Description

@mvdan

Two recent failures on linux-amd64-longtest:

https://build.golang.org/log/ef73c0ec3463104a804cba25d4b550a403db26b9
https://build.golang.org/log/6e2a1f6b524c1c8d2f794bce1bae272c87a62ef7

--- FAIL: TestServerShutdownStateNew (2.00s)
    serve_test.go:5603: shutdown too soon after 49.41µs
    serve_test.go:5617: timeout waiting for Read to unblock
FAIL
FAIL	net/http	37.294s

The test accepts shutdowns between 0.5x and 1.5x the expected amount, which is 5s. The result of not even a millisecond seems to point that the test completely breaks, as opposed to this being a timing issue. Looking into it.

/cc @bradfitz

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions