-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/bytealg: extend memchr result correctly on wasm #68400
Conversation
This PR (HEAD: c36f013) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/597955. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Zxilly Chou: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Cuong Manh Le: Patch Set 2: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Zxilly Chou: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-15T17:40:46Z","revision":"8f1818bf6052ddb2397ef598d4ba1e41420f5585"} Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Zxilly Chou: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Cherry Mui: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Zxilly Chou: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 3: -Code-Review (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
This PR (HEAD: 90bdd83) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/597955. Important tips:
|
Message from Zxilly Chou: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 4: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-17T04:58:50Z","revision":"1f6ac533bd260199c0c984543a4f2954a25b6519"} Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 4: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):
Build or test failure, click here for results. Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
This PR (HEAD: c2568b1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/597955. Important tips:
|
Message from Zxilly Chou: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 5: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-17T06:06:39Z","revision":"67e225ec9df011fe4601cbe3bcaf3ddd7d8d96cb"} Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Keith Randall: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/597955. |
The mem address should be regarded as uint32. Fixes #65571 Change-Id: Icee38d11f2d93eeca7d50b2e133159e321daeb90 GitHub-Last-Rev: c2568b1 GitHub-Pull-Request: #68400 Reviewed-on: https://go-review.googlesource.com/c/go/+/597955 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This PR is being closed because golang.org/cl/597955 has been merged. |
…tly on wasm The mem address should be regarded as uint32. Fixes #68474 Change-Id: Icee38d11f2d93eeca7d50b2e133159e321daeb90 GitHub-Last-Rev: c2568b1 GitHub-Pull-Request: #68400 Reviewed-on: https://go-review.googlesource.com/c/go/+/597955 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit 90c6558) Reviewed-on: https://go-review.googlesource.com/c/go/+/598995
…tly on wasm The mem address should be regarded as uint32. Fixes #68475 Change-Id: Icee38d11f2d93eeca7d50b2e133159e321daeb90 GitHub-Last-Rev: c2568b1 GitHub-Pull-Request: #68400 Reviewed-on: https://go-review.googlesource.com/c/go/+/597955 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit 90c6558) Reviewed-on: https://go-review.googlesource.com/c/go/+/598975
The mem address should be regarded as uint32.
Fixes #65571