golint: suggest for range when possible

[dominikh]

for _ = range and for _, _ = range can be written as
for range instead.

[dsymonds]

Thanks, but I'm not convinced this is particularly useful. for _ = range was the only option for so long and is only able to be shortened relatively recently, so it's hard to argue that the shorter form is stylistically dominant.

[dominikh]

"relatively recently" was over a year ago. I was hoping that adding the check would remind people that this is now possible. I think most people don't realize that it is.

It's something that gofmt -s simplifies (just like for x, _ := range), so it seemed to fit in for symmetry's sake.

[dsymonds]

A year isn't much time in the scheme of things to make something a standard. Go has been a public project for over 6 years. Mere availability of a language construct does not make it stylistically wrong to use the longer form, and it's not golint's place to remind people of new features, only to flag poor style.

Sorry, this doesn't pass muster.

[dominikh]

Fair enough. I'll be back in a year ;-)

[louwers]

@dominikh Here we are.

[dominikh]

I am impressed. PTAL

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[andybons]

@dominikh can you reply to @googlebot ?

[dominikh]

I signed it.

[andybons]

@googlebot cla?

[andybons]

Hm. @googlebot seems stuck. Can you confirm with your existing CLA data and verify that your email is set on your git commits? Links in #196 (comment)

[dominikh]

I think I see what happened. I had signed the CLA on my gmail account a long time ago, and added my main email (dominik@honnef.co) as an alternate email address. A while back, I turned dominik@honnef.co into a Google Apps account, so it must've detached the address from the CLA.

I have now effectively signed a second CLA, on the new account.

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[gopherbot]

This PR (HEAD: 318343f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/96176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Andrew Bonventre:

Patch Set 1: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/96176.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Andrew Bonventre:

Patch Set 1:

(1 comment)

ping adonovan

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/96176.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alan Donovan:

Patch Set 1: Code-Review+2

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/96176.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/96176.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/96176.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/96176 has been merged.