dns/dnsmessage: reject names with dots inside label #154
Conversation
|
This PR (HEAD: b258830) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/443215 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: c433dd4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/443215 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: d6d389e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/443215 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 42d0d8e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/443215 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: c61ec10) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/443215 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 8a8703a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/443215 to see it. Tip: You can toggle comments from me using the |
|
Message from Mateusz Poliwczak: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/443215. |
|
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443215. |
|
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/443215. |
|
Message from Roland Shoemaker: Patch Set 6: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/443215. |
Fixes golang/go#56246 Change-Id: I9c8d611d1305536a7510bf6c4a02a5e551aa657a GitHub-Last-Rev: 8a8703a GitHub-Pull-Request: #154 Reviewed-on: https://go-review.googlesource.com/c/net/+/443215 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Mateusz Poliwczak <mpoliwczak34@gmail.com> Auto-Submit: Roland Shoemaker <roland@golang.org>
|
This PR is being closed because golang.org/cl/443215 has been merged. |
|
This change breaks the mailbox field in SOA records. Names are allowed to have dots, at least in the email in the SOA records case. Here is an example: % dig gc.ca
; <<>> DiG 9.20.9 <<>> gc.ca
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 42837
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;gc.ca. IN A
;; AUTHORITY SECTION:
gc.ca. 1503 IN SOA ns10.ent.global.gc.ca. ssc\.enterpriseddi-entreprise\.spc.ssc-spc.gc.ca. 2025102002 10800 3600 604800 3600
;; Query time: 68 msec
;; SERVER: ::1#53(::1) (UDP)
;; WHEN: Tue Oct 21 17:18:19 -03 2025
;; MSG SIZE rcvd: 142The email there is interpreted as Currently Go fails to parse that response because of the introduced rejection. |
|
More examples: % dig washingtonpost.com AAAA
; <<>> DiG 9.20.9 <<>> washingtonpost.com AAAA
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 60461
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;washingtonpost.com. IN AAAA
;; AUTHORITY SECTION:
washingtonpost.com. 300 IN SOA sdns34.ultradns.com. admin\.contact.digitalink.com. 2016123863 3600 900 2592000 300% dig indiatimes.com HTTPS
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 43326
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;indiatimes.com. IN HTTPS
;; AUTHORITY SECTION:
indiatimes.com. 1200 IN SOA a1-127.akam.net. mukesh\.tyagi.indiatimes.co.in. 2016062870 3600 600 604800 1800These are not uncommon. It's a significant regression. |
|
@fortuna Can you open a separate GH issue about this? |
3 participants
Fixes golang/go#56246