Skip to content

dns/dnsmessage: reject packing of 255B rooted names, reject unpacking of 256B (dns encoded) names #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

dns/dnsmessage: reject packing of 255B rooted names, reject unpacking of 256B (dns encoded) names #156

wants to merge 4 commits into from

Conversation

@mateusz834
Copy link
Member

@mateusz834 mateusz834 commented Nov 5, 2022 •
edited
Loading

Packing a 255B (rooted) name will create an 256B (dns encoded) name, which is an invalid name. Similar with unpacking, we can't unpack 256B (dns encoded) name, because it is too long.

@mateusz834 mateusz834 changed the title dns/dnsmessage: reject packing of 255B (human encoded) names, reject unpacking of 256B (dns encoded) names dns/dnsmessage: reject packing of 255B (dot encoded) names, reject unpacking of 256B (dns encoded) names Nov 5, 2022
@gopherbot
Copy link
Contributor

gopherbot commented Nov 5, 2022

This PR (HEAD: 21c1869) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/448156 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Nov 6, 2022

This PR (HEAD: a4604d8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/448156 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Nov 7, 2022

Message from Damien Neil:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

Message from Mateusz Poliwczak:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

This PR (HEAD: 5873c64) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/448156 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

Message from Mateusz Poliwczak:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

Message from Damien Neil:

Patch Set 5: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

Message from Damien Neil:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2022

Message from Michael Knyszek:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@mateusz834 mateusz834 changed the title dns/dnsmessage: reject packing of 255B (dot encoded) names, reject unpacking of 256B (dns encoded) names dns/dnsmessage: reject packing of 255B rooted names, reject unpacking of 256B (dns encoded) names May 15, 2023
@mateusz834 mateusz834 force-pushed the dnsmessage-long-names branch from 5873c64 to ddf151a Compare May 15, 2023 12:12
@gopherbot
Copy link
Contributor

gopherbot commented May 15, 2023

This PR (HEAD: ddf151a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/448156 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented May 15, 2023

Message from Mateusz Poliwczak:

Patch Set 6: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented May 15, 2023

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented May 15, 2023

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448156.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 15, 2023
@mateusz834 @neild
dns/dnsmessage: reject packing of 255B rooted names, reject unpacking…
2b0b97d 
… of 256B (dns encoded) names

Packing a 255B (rooted) name will create an 256B (dns encoded) name, which is an invalid name. Similar with unpacking, we can't unpack 256B (dns encoded) name, because it is too long.

Change-Id: I17cc93a93a17a879a2a789629e56ad39999da9ac
GitHub-Last-Rev: ddf151a
GitHub-Pull-Request: #156
Reviewed-on: https://go-review.googlesource.com/c/net/+/448156
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Mateusz Poliwczak <mpoliwczak34@gmail.com>
@gopherbot
Copy link
Contributor

gopherbot commented May 15, 2023

This PR is being closed because golang.org/cl/448156 has been merged.

@gopherbot gopherbot closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mateusz834 @gopherbot