Skip to content

Conversation

@ScruffyProdigy
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Jan 19, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 09595ed) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/284632 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(18 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3aaffc9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/284632 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: ff3aac6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/284632 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ryan Kohler:

Patch Set 3:

(16 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 3:

(9 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 88fab89) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/284632 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ryan Kohler:

Patch Set 4:

(9 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ryan Kohler:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ryan Kohler:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=4c612761


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tyler Bui-Palsulich:

Patch Set 4: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tyler Bui-Palsulich:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284632.
After addressing review feedback, remember to publish your drafts!

@ScruffyProdigy ScruffyProdigy changed the title Create AWS V4 Signing Utility google: Create AWS V4 Signing Utility Jan 25, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 8cdc6a9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/284632 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Jan 25, 2021
Change-Id: I59b4a13ed0433de7dfaa064a0f7dc1f3dd724518
GitHub-Last-Rev: 8cdc6a9
GitHub-Pull-Request: #467
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/284632
Run-TryBot: Cody Oss <codyoss@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cody Oss <codyoss@google.com>
Trust: Tyler Bui-Palsulich <tbp@google.com>
Reviewed-by: Cody Oss <codyoss@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/284632 has been merged.

@gopherbot gopherbot closed this Feb 4, 2021
@ScruffyProdigy ScruffyProdigy deleted the aws-signature branch April 18, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants