Skip to content

Conversation

@gIthuriel
Copy link
Contributor

Adds support for service account impersonation when a URL for service account impersonation is provided.

@google-cla
Copy link

google-cla bot commented Jan 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 20, 2021
google: add utilities supporting upcoming oauth2 functionality
Change-Id: Ib2faa6c1533a4f1886c6d31da1a30e27a29f9453
Change-Id: I11264a2a24adb60847b0089d16621a223bf6b73e
Change-Id: I01358c49fccd68b1a343efa2c80e9371d56b75b4
Change-Id: I6481964659c2c852e50bf8b19a1306629e7cc4ae
@google-cla
Copy link

google-cla bot commented Jan 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google: add utilities supporting upcoming oauth2 functionality
Change-Id: Iaf77201a95b8564eda6cbba9641f8c89da6b8ff9
Change-Id: I11264a2a24adb60847b0089d16621a223bf6b73e
Change-Id: I01358c49fccd68b1a343efa2c80e9371d56b75b4
Change-Id: I6481964659c2c852e50bf8b19a1306629e7cc4ae
…oauth2 into service-account-impersonation

Change-Id: Ie55c0997b30b0145d4656227cff7ba08f75c99f9
Change-Id: I80d6785fd0e1e4f69c5e47d4ab9012ef5575333c
Change-Id: I11264a2a24adb60847b0089d16621a223bf6b73e
Change-Id: I01358c49fccd68b1a343efa2c80e9371d56b75b4
…oauth2 into service-account-impersonation

Change-Id: Ie55c0997b30b0145d4656227cff7ba08f75c99f9
…oauth2 into service-account-impersonation

Change-Id: I11e5508e8d5cb501b63b81f425abfb4c2cc2e256
@gIthuriel gIthuriel force-pushed the service-account-impersonation branch from a0bcc57 to 85db953 Compare January 20, 2021 19:42
@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 20, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 85db953) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/285012 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 1:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

Change-Id: I17c0283f053711f44abaf5620f2642eea08aca62
Change-Id: I92df737a7850e5283ac48c4e410297f8c778b632
@gopherbot
Copy link
Contributor

This PR (HEAD: 975d095) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/285012 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 1:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

Change-Id: I74140daa4acf876388f4f8ef83c475c1ae7d1865
@gopherbot
Copy link
Contributor

This PR (HEAD: 9901730) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/285012 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 3:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

Change-Id: I80810189246ee1d7c2dba570b7ec72899b04d265
@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 0cc2c09) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/285012 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4: Run-TryBot+1 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=9ec537ab


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tyler Bui-Palsulich:

Patch Set 4: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

Change-Id: I662df725703b5fbc109c2b3bcdb9780424619bdc
@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 4:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 9c21878) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/285012 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Jan 26, 2021
Adds support for service account impersonation when a URL for service account impersonation is provided.

Change-Id: I9f3bbd6926212cecb13938fc5dac358ba56855b8
GitHub-Last-Rev: 9c21878
GitHub-Pull-Request: #468
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/285012
Run-TryBot: Cody Oss <codyoss@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cody Oss <codyoss@google.com>
Trust: Tyler Bui-Palsulich <tbp@google.com>
Reviewed-by: Cody Oss <codyoss@google.com>
@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 5: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f74621a6


Please don’t reply on this GitHub thread. Visit golang.org/cl/285012.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/285012 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants