Skip to content

google: support AWS 3rd party credentials #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

google: support AWS 3rd party credentials #471

wants to merge 4 commits into from

Conversation

@ScruffyProdigy
Copy link
Contributor

@ScruffyProdigy ScruffyProdigy commented Jan 28, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jan 28, 2021
@gopherbot
Copy link
Contributor

gopherbot commented Jan 28, 2021

This PR (HEAD: d6857d1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/287752 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jan 29, 2021

Message from Cody Oss:

Patch Set 1:

(26 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jan 30, 2021

This PR (HEAD: ba9ae8c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/287752 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jan 30, 2021

Message from Ryan Kohler:

Patch Set 2:

(22 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

Message from Cody Oss:

Patch Set 2: Trust+1

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

This PR (HEAD: 471b94b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/287752 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

This PR (HEAD: 648f0b3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/287752 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

Message from Ryan Kohler:

Patch Set 2:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

Message from Cody Oss:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

Message from Cody Oss:

Patch Set 4: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

Message from Go Bot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=c0fd7795

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

Message from Go Bot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

Message from Tyler Bui-Palsulich:

Patch Set 4: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/287752.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 1, 2021
@codyoss
google: support AWS 3rd party credentials
0101308 
Change-Id: I655b38f7fb8023866bb284c7ce80ab9888682e73
GitHub-Last-Rev: 648f0b3
GitHub-Pull-Request: #471
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/287752
Reviewed-by: Cody Oss <codyoss@google.com>
Run-TryBot: Cody Oss <codyoss@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Tyler Bui-Palsulich <tbp@google.com>
Trust: Cody Oss <codyoss@google.com>
@gopherbot
Copy link
Contributor

gopherbot commented Feb 1, 2021

This PR is being closed because golang.org/cl/287752 has been merged.

@gopherbot gopherbot closed this Feb 1, 2021
@ScruffyProdigy ScruffyProdigy deleted the aws-signer branch April 18, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScruffyProdigy @gopherbot