Skip to content

google: Changes required to get AWS working in manual testing #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

google: Changes required to get AWS working in manual testing #474

wants to merge 1 commit into from

Conversation

@ScruffyProdigy
Copy link
Contributor

@ScruffyProdigy ScruffyProdigy commented Feb 9, 2021

• Subject Token needs to be query escaped
• Null options need to be omitted (like they are in other languages)

@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@gopherbot
Copy link
Contributor

gopherbot commented Feb 9, 2021

This PR (HEAD: 1aae076) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/290513 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Feb 9, 2021

Message from Cody Oss:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/290513.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 9, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=07e0f4ed

Please don’t reply on this GitHub thread. Visit golang.org/cl/290513.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 9, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/290513.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 10, 2021
@codyoss
google: Changes required to get AWS working in manual testing
6667018 
• Subject Token needs to be query escaped
• Null options need to be omitted (like they are in other languages)

Change-Id: I67d1ed3ba96a35283a8928f196bc7e912084d1ab
GitHub-Last-Rev: 1aae076
GitHub-Pull-Request: #474
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/290513
Reviewed-by: Cody Oss <codyoss@google.com>
Trust: Cody Oss <codyoss@google.com>
Trust: Tyler Bui-Palsulich <tbp@google.com>
Run-TryBot: Cody Oss <codyoss@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor

gopherbot commented Feb 10, 2021

This PR is being closed because golang.org/cl/290513 has been merged.

@gopherbot gopherbot closed this Feb 10, 2021
@ScruffyProdigy ScruffyProdigy deleted the aws-manual branch April 18, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScruffyProdigy @gopherbot