google: unexport private structs and funcs #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ScruffyProdigy wants to merge 1 commit into golang:master from ScruffyProdigy:unexport

Contributor

ScruffyProdigy commented Feb 18, 2021 •

edited

Loading

These structs and funcs cannot be used by the end consumer. Unexporting them helps cleans up our documentation


          google: Unexport private structs and funcs

60b58ee

These structs and funcs should not be used by the end consumer.
Unexporting them prevents developer confusion and unintended usage, as
well as cleans up our documentation

google-cla bot added the cla: yes label

Contributor

gopherbot commented Feb 18, 2021

This PR (HEAD: 60b58ee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/293752 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Feb 18, 2021

Message from Cody Oss:

Patch Set 1: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/293752.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 18, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=cc429a30

Please don’t reply on this GitHub thread. Visit golang.org/cl/293752.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 18, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/293752.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 18, 2021

Message from Cody Oss:

Patch Set 1: Run-TryBot+1 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/293752.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 18, 2021

Message from Tyler Bui-Palsulich:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/293752.
After addressing review feedback, remember to publish your drafts!

Contributor Author

ScruffyProdigy commented Feb 18, 2021

Attempting to update the message

gopherbot pushed a commit that referenced this pull request


          google: unexport private structs and funcs

ba52d33

These structs and funcs cannot be used by the end consumer. Unexporting them helps cleans up our documentation

Change-Id: I2eadb69e87de912ac39f53e83cd9bdfe76a15e3e
GitHub-Last-Rev: 60b58ee
GitHub-Pull-Request: #479
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/293752
Reviewed-by: Cody Oss <codyoss@google.com>
Trust: Cody Oss <codyoss@google.com>
Trust: Tyler Bui-Palsulich <tbp@google.com>
Run-TryBot: Cody Oss <codyoss@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

Contributor

gopherbot commented Feb 18, 2021

This PR is being closed because golang.org/cl/293752 has been merged.

gopherbot closed this

ScruffyProdigy deleted the unexport branch

April 18, 2022 20:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels