google: check additional AWS variable #486
Conversation
…, but wasn't. Also removed a redundant print statement in a test case. Change-Id: I0de4bcd5a134f7a9af249e5ebe56dfc3d35abf6d
|
This PR (HEAD: 57bbf4f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/302789 to see it. Tip: You can toggle comments from me using the |
|
Message from Cody Oss: Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/302789. |
|
Message from Go Bot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=c62a7c73 Please don’t reply on this GitHub thread. Visit golang.org/cl/302789. |
|
Message from Go Bot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/302789. |
|
Message from Tyler Bui-Palsulich: Patch Set 1: Trust+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/302789. |
|
Message from Tyler Bui-Palsulich: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/302789. |
|
This PR (HEAD: 9de0808) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/302789 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 1a10bcc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/302789 to see it. Tip: You can toggle comments from me using the |
|
Message from Patrick Jones: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/302789. |
AWS_DEFAULT_REGION should have been checked as a backup to AWS_REGION but wasn't. Also removed a redundant print statement in a test case. Change-Id: Ia6e13eb20f509110a81e3071228283c43a1e9283 GitHub-Last-Rev: 1a10bcc GitHub-Pull-Request: #486 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/302789 Reviewed-by: Cody Oss <codyoss@google.com> Trust: Cody Oss <codyoss@google.com> Trust: Tyler Bui-Palsulich <tbp@google.com>
|
This PR is being closed because golang.org/cl/302789 has been merged. |
2 participants
AWS_DEFAULT_REGION should have been checked as a backup to AWS_REGION but wasn't. Also removed a redundant print statement in a test case.