-
Notifications
You must be signed in to change notification settings - Fork 361
_content/css: fix editor's scroll on playground #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use `display: flex` to account for the height of the `Press Esc to move...` banner when calculating the height of the editor. This fixes the bug that prevented users from scrolling to the end of the text. Fixes golang/go#63237
|
This PR (HEAD: 7727863) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/679035. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
|
Message from Nikita Shoshin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
|
Message from Sean Liao: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-06-07T10:12:59Z","revision":"5af6ddeaf0a08e1a7b4be96695d734ca215c95f3"} Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
|
Message from Sean Liao: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
|
Message from Cherry Mui: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/679035. |
Use "display: flex" to account for the height of the "Press Esc to move..." banner when calculating the height of the editor. This fixes the bug that prevented users from scrolling to the end of the text. Fixes golang/go#63237 Change-Id: I1d4c196d9b3170d766ffdd0df779c5e693a6ed5a GitHub-Last-Rev: 7727863 GitHub-Pull-Request: #323 Reviewed-on: https://go-review.googlesource.com/c/website/+/679035 Reviewed-by: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Sean Liao <sean@liao.dev>
|
This PR is being closed because golang.org/cl/679035 has been merged. |
Use "display: flex" to account for the height of the "Press Esc to move..."
banner when calculating the height of the editor.
This fixes the bug that prevented users from scrolling to the end of
the text.
Fixes golang/go#63237