unexportedglobal: Linter to require '_' prefix on globals

.golangci.reference.yml

@@ -2175,6 +2175,7 @@ linters:
     - tparallel
     - typecheck
     - unconvert
+    - unexportedglobal
     - unparam
     - unused
     - usestdlibvars
@@ -2289,6 +2290,7 @@ linters:
     - tparallel
     - typecheck
     - unconvert
+    - unexportedglobal
     - unparam
     - unused
     - usestdlibvars

go.mod

@@ -115,6 +115,7 @@ require (
 	github.com/yeya24/promlinter v0.2.0
 	github.com/ykadowak/zerologlint v0.1.3
 	gitlab.com/bosi/decorder v0.2.3
+	go.abhg.dev/unexportedglobal v0.2.1
 	go.tmz.dev/musttag v0.7.1
 	golang.org/x/exp v0.0.0-20230510235704-dd950f8aeaea
 	golang.org/x/tools v0.11.0

pkg/golinters/unexportedglobal.go

@@ -0,0 +1,16 @@
+package golinters
+
+import (
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+	"go.abhg.dev/unexportedglobal"
+	"golang.org/x/tools/go/analysis"
+)
+
+func NewUnexportedGlobal() *goanalysis.Linter {
+	return goanalysis.NewLinter(
+		"unexportedglobal",
+		"Disallows unexported globals without a '_' prefix",
+		[]*analysis.Analyzer{unexportedglobal.Analyzer},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/lint/lintersdb/manager.go

@@ -817,6 +817,13 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/mdempsky/unconvert"),
 
+		linter.NewConfig(golinters.NewUnexportedGlobal()).
+			WithSince("v1.54.0").
+			WithLoadForGoAnalysis().
+			WithPresets(linter.PresetStyle).
+			WithAutoFix().
+			WithURL("https://github.com/abhinav/unexportedglobal"),
+
 		linter.NewConfig(golinters.NewUnparam(unparamCfg)).
 			WithSince("v1.9.0").
 			WithPresets(linter.PresetUnused).

test/testdata/unexportedglobal.go

@@ -0,0 +1,15 @@
+//golangcitest:args -Eunexportedglobal
+package testdata
+
+import "fmt"
+
+var ExportedVar = 1 // ok
+
+var unexportedVar = 1 // want `unexported global "unexportedVar" should be prefixed with '_'`
+
+var _unexportedVar = 1 // ok
+
+func _1() {
+	var local = 42
+	fmt.Println(local) // ok
+}