Honor /revise on an implementation pull request#46
Merged
Conversation
The command table (shared/sdd-interaction.md) lists /revise for spec PRs, architecture PRs, and implementation PRs. sdd-spec and sdd-triage handle it; sdd-execute did not — its wrapper matched only /execute, and /execute on a PR was explicitly ignored. The contract over-promised. sdd-execute already addresses inline pull_request_review_comment events (trigger 4). This adds /revise as a second feedback path: a holistic note, where review comments are line-anchored. Both push follow-up commits to the same branch (step 7). - sdd-execute (3 tier sources): trigger 6 — /revise on an implementation PR this agent opened; step 7 handles it alongside review comments. - Wrappers (3 tiers): the issue_comment handler routes /revise on a PR with the same write-access gate as /execute, as trigger 'revise'. - Tier gate: an issue_comment event has no payload.pull_request, so the gate fetches the PR to read its `Closes #<task>` body reference. - Recompiled the 3 sdd-execute locks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR extends the sdd-execute wrapper and agent tiers (haiku, opus, sonnet) to recognize and route ChangesWrapper Routing and Agent Tier Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The command table (
shared/sdd-interaction.md) declares/revise <note>for spec PRs, architecture PRs, and implementation PRs — "re-run the owning agent."sdd-specandsdd-triagehonor it.sdd-executedid not: its wrapper'sissue_commenthandler matched only/execute, and/executeon a PR was explicitly ignored./reviseon an implementation PR was silently dropped. The contract over-promised.Fix
sdd-executealready addresses inlinepull_request_review_commentevents (trigger 4) — line-anchored feedback. This adds/reviseas a second path — a holistic instruction — so feedback on implementation PRs is uniform with spec and architecture PRs. Both paths push follow-up commits to the same branch (step 7).sdd-execute(3 tier sources): trigger 6 — a write-access/revise <note>on an implementation PR this agent opened. Step 7 handles it alongside review comments; ownership confirmed by thesdd/<task-id>-<slug>head branch.issue_commenthandler routes/reviseon a PR through the same repo-write-access gate as/execute, astrigger: 'revise',item_type: 'pull_request'.issue_commentevent carries nopayload.pull_request, so the gate fetches the PR viapulls.getto read itsCloses #<task>body reference and resolve the model tier. A/reviseon a non-implementation PR (noCloses) resolves to no task and the variant skips it.sdd-executelocks.Feedback modes after this change
/revise <note>→sdd-spec/revise <note>→sdd-triage/revise <note>or an inline review comment →sdd-executeAcceptance
/revise <note>on ansdd/*implementation PR triggers the matchingsdd-executetier; it pushes follow-up commits to the same branch./reviseon aspec/*orarch/*PR does not runsdd-execute(tier gate finds noCloses #<task>).gh aw compilereports 0 errors; no lock drift.References
shared/sdd-interaction.mdcommand table. Pairs with the diagram update on PR #44.🤖 Generated with Claude Code